feat(slab): using slab new routes to handle async tasks#70
Conversation
soonum
force-pushed
the
dt/feat/support_new_tasks
branch
2 times, most recently
from
d2c3496 to
ef7acd0
Compare
soonum
force-pushed
the
dt/feat/support_new_tasks
branch
from
ef7acd0 to
1641b21
Compare
| } catch (error) { | ||
| core.info(`Clean up after error, stop ${provider} instance`) | ||
| await slab.stopInstanceRequest(startInstanceResponse.runner_name) | ||
| await slab.stopInstanceRequest(runnerName) |
There was a problem hiding this comment.
runner name could be empty here maybe ?
There was a problem hiding this comment.
I added an early return to avoid falling in this case.
In fact if Github operation fails in this function, the instance would not be started.
There was a problem hiding this comment.
While writting my last message I think we can go back for the previous implem.
I've to check if the instance record is not updated in case of Github error.
There was a problem hiding this comment.
I somewhat rolled back the implementation for start. Since it can be safely relaunched without having zombies.
soonum
force-pushed
the
dt/feat/support_new_tasks
branch
from
1641b21 to
b716cc3
Compare
IceTDrinker
left a comment
IceTDrinker
left a comment
There was a problem hiding this comment.
Thanks !
@IceTDrinker reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @soonum).
This ensures to wait for individual asynchronous tasks since there are GitHub-related operations and backend providers ones.
soonum
force-pushed
the
dt/feat/support_new_tasks
branch
from
b716cc3 to
fd7e64f
Compare
IceTDrinker
left a comment
IceTDrinker
left a comment
There was a problem hiding this comment.
@IceTDrinker reviewed 2 files and all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @soonum).
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 participants
This ensure to wait for individual asynchronous tasks since there are GitHub related operations and backend providers ones.
This change is